Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In v8.0.0 prettier/recommend is it imported too? #176

Closed
sandhilt opened this issue Feb 21, 2021 · 3 comments
Closed

In v8.0.0 prettier/recommend is it imported too? #176

sandhilt opened this issue Feb 21, 2021 · 3 comments

Comments

@sandhilt
Copy link

In changelog has written:

The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

Reference: CHANGELOG.md

This also included plugin:prettier/recommended ?

Sorry for the silly question, is that like the others are part of prettier/*.

@lydell
Copy link
Member

lydell commented Feb 21, 2021

Hi!

The answer is: No.

Everything in "extends" that start with plugin: comes from plugins. This is a config, so it’s not coming from this package (it comes from eslint-plugin-prettier itself). I think it’s sad that the whole eslint-config-prettier + eslint-plugin-prettier thing is so confusing. See also: https://github.com/prettier/eslint-config-prettier#arrow-body-style-and-prefer-arrow-callback

A tip for the future – it’s easy to look at the source code for ESLint configs to see exactly what they do.

@lydell
Copy link
Member

lydell commented Feb 21, 2021

One thing I forgot to mention: It’s almost the other way around. "plugin:prettier/recommended" includes the "prettier" config from this repo. So if you use eslint-plugin-prettier, "plugin:prettier/recommended" should be all you need.

@lydell lydell closed this as completed in 0fd5734 Feb 21, 2021
@lydell
Copy link
Member

lydell commented Feb 21, 2021

See also #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants