"prettier.eslintIntegration": true not working on Windows 10

[GollyJer]

I've run into this problem with the prettier-eslint-vscode extension and tried yours without any luck as well.

I'm running this version of vscode.

and prettier gets applied but eslint --fix does not.

[CiGit]

I've just tried a freshly installed insider on Windows 10 and eslintIntegration without any trouble.
Can you share a minimal input code and your settings which exposes the problem you have?

[GollyJer]

Hi @CiGit. Thanks for the response!

With that info I was able to track the problem down to, strangely, the Git Lens extension.

Can you install it and see if it breaks for you?

[CiGit]

Tested on Archlinux, stable vscode, a lot of extensions (including git lens) without having errors. Will try on Windows 10 later.
Is this issue relevant to #96 ?

[GollyJer]

I don't think #96 is related to my issue.

Just to isolate further I disabled every extension except for yours and GitLens and added only "prettier.eslintIntegration": true to my settings.json file.

The problem is 100% reproduce-able.
With GitLens, no eslint --fix. Without GitLens it works as expected.

The same interference happens with @RobinMalfait's extension.

[CiGit]

That's really weird...
Windows 10 + vscode stable + git lens without troubles.

[CiGit]

Please update to latest version, It updates prettier-eslint...
It's worth a try 😆

[GollyJer]

Definitely weird!
New version doesn't fix anything. :-/

The only thing I can think of is that I'm on vscode-insiders.
I'll do without GitLens for now. 😄

Thanks for trying.

[CiGit]

Tried with Insider + Git Lens + eslintIntegration.
I've got the same behavior you described. It seems it also breaks eslint extension.

Quick and Dirty fix

By patching ~\.vscode-insiders\extensions\eamodio.gitlens-3.5.1\node_modules\zone.js\dist\zone-node.js:816

 if (ZoneAwareError[stackRewrite] && error.originalStack) {

to

if (ZoneAwareError[stackRewrite] && typeof error.originalStack === 'string') {

Prettier-vscode runs smoothly. Git lens seems to work too.

[GollyJer]

A fix from the GitLens side is in the works.

[CiGit]

Thanks.
There is nothing we can do on our side. Closing

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.