Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL: Enable empty fields when released #3619

Closed
vjeux opened this issue Dec 31, 2017 · 2 comments
Closed

GraphQL: Enable empty fields when released #3619

vjeux opened this issue Dec 31, 2017 · 2 comments
Labels
lang:graphql Issues affecting GraphQL locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:enhancement A potential new feature to be added, or an improvement to how we print something

Comments

@vjeux
Copy link
Contributor

vjeux commented Dec 31, 2017

Add support back for

type X {}

Option to enable it:

{
  allowLegacySDLEmptyFields: true,
}

See #3605 for the prettier patch that remove support for it.
See graphql/graphql-js#1171 for the graphql PR that added support back (not yet in a release)
@vjeux vjeux mentioned this issue Dec 31, 2017
Closed
@duailibe duailibe added lang:graphql Issues affecting GraphQL type:enhancement A potential new feature to be added, or an improvement to how we print something labels Dec 31, 2017
@lydell
Copy link
Member

lydell commented Sep 23, 2018

Is this something we still want to do? The graphql-js PR was released over half a year ago and we’ve had zero issues opened about this.

@vjeux vjeux closed this as completed Sep 23, 2018
@vjeux
Copy link
Contributor Author

vjeux commented Sep 23, 2018

Less work :)

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Dec 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lang:graphql Issues affecting GraphQL locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:enhancement A potential new feature to be added, or an improvement to how we print something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vjeux @duailibe @lydell