Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript 3.7] declare modifier on class fields #6661

Closed
thorn0 opened this issue Oct 15, 2019 · 1 comment · Fixed by #6657
Closed

[TypeScript 3.7] declare modifier on class fields #6661

thorn0 opened this issue Oct 15, 2019 · 1 comment · Fixed by #6657
Labels
lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program

Comments

@thorn0
Copy link
Member

thorn0 commented Oct 15, 2019

see microsoft/TypeScript#33509

Prettier 1.18.2
Playground link

--parser typescript

Input:

class C extends B {
  declare p: 25
}

Output:

class C extends B {
  p: 25;
}

Expected behavior:

same as the input

@alexander-akait alexander-akait added lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) type:bug Issues identifying ugly output, or a defect in the program labels Oct 15, 2019
@thorn0 thorn0 added the scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency label Oct 17, 2019
@Cryrivers
Copy link
Contributor

As discussed in #6657, we are waiting for typescript-eslint/typescript-eslint#1086.

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 26, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants