Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indented checkbox icons behave strangely in reading view #245

Closed
kkriszt opened this issue Sep 24, 2024 · 3 comments
Closed

Indented checkbox icons behave strangely in reading view #245

kkriszt opened this issue Sep 24, 2024 · 3 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@kkriszt
Copy link

kkriszt commented Sep 24, 2024

Primary Theme Version

v.2.9.1

Debug Info

SYSTEM INFO:
Obsidian version: v1.7.2
Installer version: v1.6.5
Operating system: Windows 11 Pro 10.0.22631
Login status: logged in
Language: en
Catalyst license: insider
Insider build toggle: on
Live preview: on
Base theme: light
Community theme: Primary v2.9.1
Snippets enabled: 0
Restricted mode: off
Plugins installed: 0
Plugins enabled: 0

RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.

Describe the enhancement

In reading mode, some checkbox icons appear strangely when they are indented under a specific checkbox icon. Their behavior is not consistent, they behave differently depending on which checkbox icon is the parent.

Here are few examples:
primary-theme-checkbox-glitches-schedule
primary-theme-checkbox-glitches-in-progress
primary-theme-checkbox-glitches-question

@kkriszt kkriszt added the 🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization label Sep 24, 2024
@ceciliamay ceciliamay self-assigned this Sep 24, 2024
@ceciliamay ceciliamay moved this to Todo in ⭕ All Tasks Sep 24, 2024
@ceciliamay ceciliamay added 🐛 bug Something isn't working and removed 🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization labels Sep 24, 2024
@ceciliamay
Copy link
Collaborator

ceciliamay commented Sep 24, 2024

woah that's wild. thanks for posting this! i will be investigating this today and will drop some notes so i have one source of truth.

CleanShot 2024-09-24 at 15 20 54@2x

CleanShot 2024-09-24 at 15 21 38@2x

CleanShot 2024-09-24 at 15 22 14@2x

CleanShot 2024-09-24 at 15 22 57@2x

CleanShot 2024-09-24 at 15 23 22@2x

CleanShot 2024-09-24 at 15 23 49@2x

CleanShot 2024-09-24 at 15 24 07@2x

CleanShot 2024-09-24 at 15 24 26@2x

CleanShot 2024-09-24 at 15 24 43@2x

CleanShot 2024-09-24 at 15 25 09@2x

CleanShot 2024-09-24 at 15 25 23@2x

CleanShot 2024-09-24 at 15 25 47@2x

CleanShot 2024-09-24 at 15 26 19@2x

Summary

  • the children checkboxes take in the styling of the parent i.e. the gradient background of the in progress, the rotate transform on resched plane icon and pinned note icon
  • another bug only in reading mode: when checkbox is hovered, background is accent color (which shouldn't be there, especially if the checkbox icon does not utilize background i.e. pin icon)
  • approach: isolate the styling

@github-project-automation github-project-automation bot moved this from Todo to Done in ⭕ All Tasks Sep 24, 2024
@ceciliamay
Copy link
Collaborator

i was able to fix the icons! but i couldn't fix the cancelled checkbox icon applying the strikethrough to its children (the goal was that the strikethrough only applies to that line like in preview). i will try to follow this up with a better solution in the future, but i have pushed the fix for this now. so please try updating your theme :)

@kkriszt
Copy link
Author

kkriszt commented Sep 24, 2024

Oh, nice, that was faaaast! 🚀 Thank you very much for designing, developing and maintaining this amazing theme! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants