Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Menubar Submenu positioning #120

Closed
mores opened this issue Apr 20, 2015 · 5 comments
Closed

Improve Menubar Submenu positioning #120

mores opened this issue Apr 20, 2015 · 5 comments
Assignees
Labels
5.1.16 5.2.1 🐞 defect Bug...Something isn't working
Milestone

Comments

@mores
Copy link

mores commented Apr 20, 2015

Original Bug: https://code.google.com/p/primefaces/issues/detail?id=5987

Testcase using 5.2. can be found here: https://github.com/mores/maven-examples/tree/master/prime-menuBar
clone; mvn jetty:run

As you can see from the picture - New -> Project can not bee seen.
primemenu

@cagataycivici
Copy link
Member

Thank you, we'll review.

@cagataycivici cagataycivici changed the title Fly Out MenuBar cumbersome due to fix for Issue 5799 Improve Menubar Submenu positioning Apr 21, 2015
@cagataycivici
Copy link
Member

I've applied flipfit collision algorithm and removed scrollbars as it breaks nested submenus.

See flipfit at;

http://api.jqueryui.com/position/

It will also take care of horizontal collision as well.

@cagataycivici cagataycivici added 🐞 defect Bug...Something isn't working 5.1.16 5.2.1 labels Apr 21, 2015
@cagataycivici cagataycivici self-assigned this Apr 21, 2015
@cagataycivici cagataycivici added this to the 5.3 milestone Apr 21, 2015
@VsevolodGolovanov
Copy link
Contributor

@cagataycivici, it seems like this fix was lost when @mertsincan was messing up menu.js in #121.
More interestingly, the fix is not present in the current menu.js on GitHub, yet somehow the fix is there in the 5.2.8 Elite release. I wonder, how could that happen? I guess you have a private repository with branches for maintaining different versions?
Anyway, the fix is lost in the public repository.

@cagataycivici
Copy link
Member

Not sure, what is happening, need to investigate.

@cagataycivici
Copy link
Member

I cannot replicate the issue and the fix is in menu.js here at GitHub. No private repos for 5.x major releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.1.16 5.2.1 🐞 defect Bug...Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants