Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quill from 1.3.1 to 1.3.3 #2803

Closed
erickdeoliveiraleal opened this issue Oct 11, 2017 · 7 comments
Closed

Update quill from 1.3.1 to 1.3.3 #2803

erickdeoliveiraleal opened this issue Oct 11, 2017 · 7 comments
Labels
enhancement Additional functionality to current component

Comments

@erickdeoliveiraleal
Copy link
Contributor

slab/quill@v1.3.1...v1.3.3

@tandraschko tandraschko added the enhancement Additional functionality to current component label Oct 11, 2017
@jxmai
Copy link
Contributor

jxmai commented Oct 11, 2017

We really should evaluate the regression first since 1.3.0. See #2802

@tandraschko
Copy link
Member

First, we should check if fixed in 1.3.3.
If not, try if we can workaround it in PF, otherwise create a issue there.
However, i don't have time sry.

@jxmai
Copy link
Contributor

jxmai commented Oct 11, 2017

Agree. will take a look later

@jxmai
Copy link
Contributor

jxmai commented Oct 11, 2017

Update quill to 1.3.3 does not fix the problem. More details will be post back to #2802. I suspect the issue is triggered by the change of picker.js in quill js. by slab/quill@83bc691 Not 100% sure yet.

Also that commit was a part of the 1.3.0 released, which strengthen my assumption

https://github.com/quilljs/quill/releases

image

@jxmai
Copy link
Contributor

jxmai commented Oct 11, 2017

Analysis in #2802 (comment), but I lean toward downgrade quill back to 1.2.6 for PF 6.2.

@jxmai
Copy link
Contributor

jxmai commented Nov 9, 2017

@tandraschko This issue can be closed since I can confirm 1.3.3 is also a buggy version.


I am currently negotiating with quill maintainer for that regression, and it might take some time. Hopefully we can see some result soon. 🙏

@tandraschko
Copy link
Member

All right, please come back if you have news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality to current component
Projects
None yet
Development

No branches or pull requests

3 participants