Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS in triStateCheckbox #3772

Closed
cnsgithub opened this issue Jun 12, 2018 · 2 comments
Closed

XSS in triStateCheckbox #3772

cnsgithub opened this issue Jun 12, 2018 · 2 comments
Labels
🔒 security Security related issue or enhancement
Milestone

Comments

@cnsgithub
Copy link
Contributor

1) Environment

  • PrimeFaces version: 6.3-snapshot

2) Expected behavior

Proper escaping of attributes stateOneTitle, stateTwoTitle, stateThreeTitle.

3) Actual behavior

The mentioned attributes are not escaped at all.

4) Steps to reproduce

Modify first p:triStateCheckbox of showcase to
<p:triStateCheckbox value="#{triStateCheckboxView.value1}" stateOneTitle="&quot; onmouseover=&quot;alert('stateOneTitle xss');&quot; " stateTwoTitle="&quot; onmouseover=&quot;alert('stateTwoTitle xss');&quot; " stateThreeTitle="&quot; onmouseover=&quot;alert('stateThreeTitle xss');&quot; "/>

Hovering first checkbox will trigger alert box.

5) Sample XHTML

see above

6) Sample bean

showcase

@cnsgithub
Copy link
Contributor Author

@tandraschko Could you please add the security label? Thanks.

Pull request: #3773. Please carefully read the PR comment.

@Rapster Rapster added the 🔒 security Security related issue or enhancement label Jun 12, 2018
@cnsgithub
Copy link
Contributor Author

Ah okay, @Rapster is a member now and also may add those labels. 😉

@tandraschko tandraschko added this to the 6.3 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔒 security Security related issue or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants