Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p:dataTable> using scrollable and scrollHeight attributes causes Uncaught TypeError #419

Closed
Three97 opened this issue Jun 10, 2015 · 6 comments
Assignees
Labels
5.2.7 🐞 defect Bug...Something isn't working
Milestone

Comments

@Three97
Copy link

Three97 commented Jun 10, 2015

In Chrome (v.43.0.2357.65), Firefox (v.28.0 & 38.0.5) and Opera (v.30.0) using PrimeFaces v5.2's DataTable works great when the vertical scrollbar is not enabled. However, when it is enabled, getting "Uncaught TypeError: Cannot read property 'webkit' of undefined". The code fails with the "$.browser" property as it is not defined. Appears to be "scrollable" related, but was not able to isolate to horizontal or vertical.

Using Eclipse Luna SR1 (4.4.1) with OEPE & WebLogic v12.1.3.2 on Windows 7 platform.

@cagataycivici
Copy link
Member

Is it possible to send a test.xhtml and TestView.java to replicate?

@Three97
Copy link
Author

Three97 commented Jun 11, 2015

Thank you for the reply. I will try to abstract the page data so as not to impose on potentially sensitive data and provide a stand-alone example. Hopefully in the next day or two?

@cagataycivici
Copy link
Member

Sure, I've found a reference to $.browser, we usually use PrimeFaces.env.browser but just want to make sure we fix your issue.

@Three97
Copy link
Author

Three97 commented Jun 11, 2015

I've seen references to replacing $.browser with PrimeFaces.env.browser in some of the recent commits, so I suspect replacing the former with the latter would fix it, but not 100% sure, of course. I was attempting to find the issue more specifically by grabbing the latest and debugging locally, but have not been successful in getting it to run yet...

@cagataycivici
Copy link
Member

Ok, I'll just do the same and close this one, it should fix it I think.

@cagataycivici cagataycivici added this to the 5.3 milestone Jun 15, 2015
@cagataycivici cagataycivici added the 🐞 defect Bug...Something isn't working label Jun 15, 2015
@cagataycivici cagataycivici self-assigned this Jun 15, 2015
@Three97
Copy link
Author

Three97 commented Jun 16, 2015

I'm afraid I may have reported an issue that no longer exists...I pulled version 5.2 using Maven, but according to this post, it appears to have been addressed: http://forum.primefaces.org/viewtopic.php?f=3&t=41656. I apologize for bringing this up if that's the case. Not sure what version is being used in the showcase, but that may explain why the error isn't showing up there (new version with fix), but is in my case (older version without fix). I do hope this didn't cause any undue confusion. This may be a different component using a similar mechanism for identifying the browser, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.2.7 🐞 defect Bug...Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants