Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable rowExpansion bug with Angular 2.2 #1366

Closed
ribizli opened this issue Nov 19, 2016 · 9 comments
Closed

DataTable rowExpansion bug with Angular 2.2 #1366

ribizli opened this issue Nov 19, 2016 · 9 comments

Comments

@ribizli
Copy link

ribizli commented Nov 19, 2016

Hi, I've reported this bug on angular's github, but I'd like to submit it here too, that you can be aware of it: angular/angular#12968

@bogacg
Copy link

bogacg commented Nov 19, 2016

Similar to #1346

@ribizli
Copy link
Author

ribizli commented Nov 20, 2016

I've reproduced the issue outside PrimeNG (see my comment on the original issue on angular), and also found a workaround: reference the row expansion template in DataTable either by a directive or by name.
Actually I've already added an issue about this long time ago: #966

@ribizli
Copy link
Author

ribizli commented Nov 22, 2016

Guys! I just warn you, the fix of this and #966 might be a future breaking change if you do after final release.

@cagataycivici
Copy link
Member

Fixed via #1396

@ribizli
Copy link
Author

ribizli commented Nov 24, 2016

It's still not working: http://embed.plnkr.co/bJ0ln941VPbUX7KP3Mtk/
From the 2nd opening it messes up the template variables.
I don't say, that this is not an angular issue, but can be avoided when not using TemplateRef but some more specific.

@bogacg
Copy link

bogacg commented Nov 24, 2016

I still have same problem even after upgrading to PrimeNG 1.0.0

@ribizli
Copy link
Author

ribizli commented Nov 24, 2016

I've opened a new issue for this.

@bogacg
Copy link

bogacg commented Nov 24, 2016

Ok, I've narrowed down to this:
IF I remove *ngFor I have inside template area (for an array property I have in each row element) I don't have any problems. As soon as I introduce that, expander messes up.

@ribizli
Copy link
Author

ribizli commented Nov 24, 2016

I've figured this out already, mentioned in every issue I've created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants