Dialog: Close Buttons must have discernible text

[HellinSunWTW]

Describe the bug

The Axe Dev Tools for Accessibility is reporting that the 'Buttons must have discernible text':

Can we have appropriate aria label like "Close the dialog" added please?

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

1. Install the Axe Dev Tools for Accessibility plug-in.
2. Visit the PrimeNG dialog page (https://primeng.org/dialog) on Chrome/Edge browser.
3. Scan the page with Axe

Expected behavior

No response

[TaneliTuomola]

There is actually a undocumented property "closeAriaLabel" that can be used to set aria-label to the close button.
<p-dialog header="Header" closeAriaLabel="Close">
Documents should be updated.

[Draganlazarev90]

There is actually a undocumented property "closeAriaLabel" that can be used to set aria-label to the close button. <p-dialog header="Header" closeAriaLabel="Close"> Documents should be updated.

this doesn't work with dynamic dialog. When you add the closeAriaLabel in the config it still doesn't apply it to the close button

[TaneliTuomola]

There is actually a undocumented property "closeAriaLabel" that can be used to set aria-label to the close button. <p-dialog header="Header" closeAriaLabel="Close"> Documents should be updated.

this doesn't work with dynamic dialog. When you add the closeAriaLabel in the config it still doesn't apply it to the close button

#15144

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[github-actions]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

[itworksafisher]

Shouldn't this be using primeng setTranslations? I would expect that to have a close property that would then be used by default for the dialogs rather than requiring consumer to provide one to each instance. DynamicDialog seems to do it.