Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JS based hover and focus with pseudo classes #1536

Closed
cagataycivici opened this issue Dec 8, 2016 · 2 comments
Closed

Replace JS based hover and focus with pseudo classes #1536

cagataycivici opened this issue Dec 8, 2016 · 2 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
2.0-RC1

Comments

@cagataycivici
Copy link
Member

Instead of adding and removing ui-state-hover and ui-state-focus, use :hover and :focus in favor less js execution and less code.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 8, 2016
@cagataycivici cagataycivici added this to the 2.0 milestone Dec 8, 2016
@cagataycivici cagataycivici self-assigned this Dec 8, 2016
@marshroomiv
Copy link

That's great, it will reduce change detection

@cagataycivici
Copy link
Member Author

Yes, that is another important benefit.

@cagataycivici cagataycivici modified the milestones: 2.0, 1.1.1 Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
2.0-RC1
Development

No branches or pull requests
2 participants
@cagataycivici @marshroomiv