Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dialog: log ERROR when closable is false or not set #16852

Closed
aboudard opened this issue Nov 26, 2024 · 3 comments
Closed

Dynamic Dialog: log ERROR when closable is false or not set #16852

aboudard opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Milestone

Comments

@aboudard
Copy link

aboudard commented Nov 26, 2024

Describe the bug

When running an open method on DialogService, is you set [closable] to false, or omit the input, the console is logging an ERROR like this:
ERROR RangeError: Maximum call stack size exceeded
image

Environment

Local environnement Windows 11, reproduced on StackBlitz, see below

Reproducer

https://stackblitz.com/edit/github-5euggt?file=src%2Fapp%2Fapp.component.ts

Angular version

18.1.0

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

Chrome 131

Steps to reproduce the behavior

Run the project, click on the button, check the console in devtools.

Expected behavior

Should not log an ERROR in any case.

@aboudard aboudard added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 26, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 26, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 26, 2024
@mehmetcetin01140 mehmetcetin01140 added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 26, 2024
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Nov 26, 2024
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@aboudard
Copy link
Author

I just edited the issue with another Stackblitz, based on the PrimeNg template.
The ERROR is there. I also reproduced the bug in the showcase application with a newly created component.

@JakeAi
Copy link

JakeAi commented Dec 2, 2024

I also have this issue @mehmetcetin01140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
Status: Done
Development

No branches or pull requests

4 participants