-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel: Panel Content focusable and announced by assistive technology even when collapsed #16972
Closed
Labels
Component: Accessibility
Issue or pull request is related to WCAG or ARIA
Milestone
Comments
roesnera
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
Dec 7, 2024
roesnera
added a commit
to roesnera/primeng
that referenced
this issue
Dec 7, 2024
Uses renderer2 to alter the tabindexing for all children of the div.p-panel-content that are typically focusable
roesnera
added a commit
to roesnera/primeng
that referenced
this issue
Dec 7, 2024
Uses renderer2 to alter the tabindexing for all children of the div.p-panel-content that are typically focusable
mertsincan
added
Status: Pending Review
Issue or pull request is being reviewed by Core Team
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Dec 11, 2024
mehmetcetin01140
added
Status: Discussion
Issue or pull request needs to be discussed by Core Team
and removed
Status: Pending Review
Issue or pull request is being reviewed by Core Team
labels
Dec 11, 2024
mehmetcetin01140
added
Component: Accessibility
Issue or pull request is related to WCAG or ARIA
and removed
Status: Discussion
Issue or pull request needs to be discussed by Core Team
labels
Dec 12, 2024
mehmetcetin01140
added a commit
that referenced
this issue
Dec 12, 2024
Fixed #16972 | Panel: Panel Content focusable and announced by assist…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using toggleable panel components, the content of the panel is still focusable when collapsed and therefore available to screen readers. This makes it confusing and inconsistent for users who navigate around using just the keyboard, as they will be focusing content that is not displayed visually, and screen readers will still announce these elements despite their parent element having aria-hidden="true" because their content is focusable.
Environment
I encountered this bug using Orca and the Ungoogled Chromium browser, and I have been advised that it also occurs when using Jaws in an unspecified browser.
Reproducer
https://stackblitz.com/edit/github-w4fae2w1?file=src%2Fapp%2Fapp.component.html
Angular version
18.0.1
PrimeNG version
18.0.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
20.17.0
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
Once the panel is collapsed and the focusable content is focused, you can interact with it as normal using your keyboard. If you are using assistive technology, you can also prompt it to announce the focused element, despite being the child of an element that (when the panel is in a collapsed state) is marked with "aria-hidden='true'"
The text was updated successfully, but these errors were encountered: