Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table column resizing fix disappeared? #17458

Open
4 tasks
LoaderB0T opened this issue Jan 21, 2025 · 2 comments · May be fixed by #17461
Open
4 tasks

Table column resizing fix disappeared? #17458

LoaderB0T opened this issue Jan 21, 2025 · 2 comments · May be fixed by #17461
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@LoaderB0T
Copy link
Contributor

LoaderB0T commented Jan 21, 2025

Describe the bug

Hi there, in November I submitted an issue and PR for a resizing bug in the table control.

This is the issue: #16734

The PR got merged and the fix was released in 17.1.something.

For some reason when looking at the master version of primeng the fix disappeared and also seems to be gone from the git history ?

As the PR was accepted and merged before already I did not create a reproducer. If I have to I can do it.

Was this intentional or an accidental force push or something? Can the PR be merged to master again? I can confirm the bug is still present in the current master version!

Thanks & best regards,
Janik

Pull Request Link

#17461

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

#16734

Environment

windows 11, vscode, does it matter?

Angular version

19.0.0

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Create a table with sortable & resizable columns and try to resize a column. Exceptions will be thrown.

Expected behavior

No exceptions & resize works as expected

@LoaderB0T LoaderB0T added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 21, 2025
@can-oezkan
Copy link
Contributor

Your commit can be found on the v17 branch: https://github.com/primefaces/primeng/commits/v17/src/app/components/table

I think what happened is that the previous v18 branch was renamed to master, while the current master branch was renamed to v17. There was no merge from v18 to master.

You should reopen the PR. The PrimeNG will probably accept the PR again.

@LoaderB0T
Copy link
Contributor Author

@can-oezkan That makes sense! I updated the issue with the (re-)opened PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants