Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree & TreeSelect: p-tree-node-toggle-button missing aria-label #17463

Open
4 tasks
TaneliTuomola opened this issue Jan 22, 2025 · 0 comments · May be fixed by #17464
Open
4 tasks

Tree & TreeSelect: p-tree-node-toggle-button missing aria-label #17463

TaneliTuomola opened this issue Jan 22, 2025 · 0 comments · May be fixed by #17464
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@TaneliTuomola
Copy link
Contributor

TaneliTuomola commented Jan 22, 2025 •
edited
Loading

Describe the bug

The toggleAriaLabel input exists in the Tree component but has not been used. The same input should also be added to the TreeSelect component, which uses the Tree component to display the tree.

Pull Request Link

#17464

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/treeselect

Environment

https://primeng.org/treeselect

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/treeselect
Check toggleBtn html.

Expected behavior

Aria-label is added to the toggle button.
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 22, 2025
@TaneliTuomola TaneliTuomola linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tree toggle btn aria-label TaneliTuomola/primeng
1 participant
@TaneliTuomola