Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown and Autocomplete component inside Datatable(Primeng: 2.0.0-rc.1). #1877

Closed
Nattujessy opened this issue Jan 21, 2017 · 3 comments
Closed

Comments

@Nattujessy
Copy link

Nattujessy commented Jan 21, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

I updated primeng: 2.0.0-rc.1 and found followings,

  1. Scrollable DataTable headers are not fit with datatable rows until get scrollbar.
  2. scrollHeight in percentage is not working. where as it worked in pervious versions.
  3. RowIndex number is showing as 'NaN'
  4. Dropdown in last line of scrollable datatable is not visible.
    • Will be better if the suggestion list gets populated in upwards when its dont have space to show at bottom.
  5. Performance of autocomplete is low.
    • If i have 2 autocomplete component in 30+ rows of datatable then the click event of an component became slow.
    • The click event focusing the cursor in autocomplete component after 1 or 2 seconds.
      Please see images for your reference https://www.screencast.com/t/1I5XJkjUSQQ
      Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Browser: Chrome 55
os: win32 x64 4gb RAM

  • Angular version: 2.4.4

angular-cli: 1.0.0-beta.19-3

  • PrimeNG version: 2.0.0-rc.1
  • Browser: [all | Chrome 55 | Firefox 50 | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@Emdee89
Copy link

Emdee89 commented Jan 22, 2017

Can also confirm that "rowIndex" in datatable column template appears as NaN. Here is my code:

This breaks the entire data table.

@Nattujessy
Copy link
Author

Here is my code:
<p-column> <template pTemplate="header"> <span class="fa fa-plus-circle" (click)="addNewLineItem()"></span> </template> <template let-rowIndexValue="rowIndex" pTemplate="body"> <p >{{rowIndexValue}}</p> </template> </p-column>
It showing "rowIndex" as NaN.

@Nattujessy
Copy link
Author

A lot more releases are came..
and Point number 3, 4 & 5 are fixed in latest versions.
hence closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants