Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule does not show date over the full Start/End range #2016

Closed
wonbyte opened this issue Feb 7, 2017 · 3 comments
Closed

Schedule does not show date over the full Start/End range #2016

wonbyte opened this issue Feb 7, 2017 · 3 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team

Comments

@wonbyte
Copy link

wonbyte commented Feb 7, 2017

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
After creating a new event, the event always displays one less than the end date.

Expected behavior
The event should display across the Start/End date.

Minimal reproduction of the problem with instructions
go to http://www.primefaces.org/primeng/#/schedule and create an event Start: 2017-02-14 End: 2017-02-17

The event will only cover 2017-02-14 to 2017-02-16.

It should cover up to 2017-02-17

Please tell us about your environment:
Windows 7, Mac

  • Angular version: 2.0.X

  • PrimeNG version: 2.0.X

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Safari (latest), Chrome(latest)

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@wonbyte wonbyte closed this as completed Feb 8, 2017
@wonbyte wonbyte reopened this Feb 8, 2017
@cagataycivici cagataycivici self-assigned this Feb 23, 2017
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 23, 2017
@cagataycivici cagataycivici added this to the 2.0.2 milestone Feb 23, 2017
@cagataycivici
Copy link
Member

As far as I know this is by design of fullcalendar;

fullcalendar/fullcalendar#2653

@cagataycivici
Copy link
Member

More information at endDate section;

https://fullcalendar.io/docs1/event_data/Event_Object/

@cagataycivici cagataycivici removed this from the 2.0.2 milestone Mar 3, 2017
@doncatnip
Copy link

doncatnip commented Jun 19, 2018

These docs say: "For example, if the last full day of an event is Thursday, the exclusive end of the event will be 00:00:00 on Friday! "
Which is not what happens for allDay background events. The 'exclusive' end of that event displayed is Thursday, one day early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

No branches or pull requests

3 participants