Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable row deselection should optionally require the meta/ctrl key #2055

Closed
ivanhosgood opened this issue Feb 13, 2017 · 1 comment
Closed

Comments

@ivanhosgood
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35


**Plunkr Case (Bug Reports)**
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

Functionality evident at: http://www.primefaces.org/primeng/#/datatable/selection

**Current behavior**
<!-- Describe how the bug manifests. -->
Within the datatable component, row de-selection requires pressing the ctrl/command key while you de-select the row

**Expected behavior**
<!-- Describe what the behavior would be without the bug. -->
I would prefer if this was configurable. If the metakey is not configured, clicking on a row should toggle the selection

**Minimal reproduction of the problem with instructions**
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example, 
please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
Functionality evident at: http://www.primefaces.org/primeng/#/datatable/selection


**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->
Usability. It took a good 5 minutes to work out that row deselection had been implemented but required the use of the ctrl/command key

**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
Windows 10

* **Angular version:** 2.0.X
<!-- Check whether this is still an issue in the most recent Angular version -->
2.4.7

* **PrimeNG version:** 2.0.X
<!-- Check whether this is still an issue in the most recent Angular version -->
2.0.0

* **Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
<!-- All browsers where this could be reproduced -->
 
* **Language:** [all | TypeScript X.X | ES6/7 | ES5]

* **Node (for AoT issues):** `node --version` =   
@cagataycivici
Copy link
Member

Fixed via;

#2098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants