Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataKey to Input List components #2357

Closed
cagataycivici opened this issue Mar 22, 2017 · 1 comment
Closed

Add dataKey to Input List components #2357

cagataycivici opened this issue Mar 22, 2017 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Mar 22, 2017

Similar to #2356;

It is not efficient to traverse all properties of objects to see if they are the same object, we have this when checking if an option is selected to add a highlight class. Instead if users can define a dataKey of the business object like dataKey="ssn", component will use this field to check if objects are equals. This is similar to rowKey in PrimeFaces or equals()-hashcode() method in java. Result will be a significant performance gain and support for immutable objects. As a fallback for backward compatibility, we'll keep the old way of property comparison.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 22, 2017
@cagataycivici cagataycivici self-assigned this Mar 22, 2017
@cagataycivici cagataycivici modified the milestone: 4.0.RC2 Mar 22, 2017
@cagataycivici cagataycivici removed the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 22, 2017
@cagataycivici
Copy link
Member Author

I don't think we can do this due to preselection where we need to compare against value.

@cagataycivici cagataycivici changed the title Use label to identify selected item(s) in input components Add dataKey to Input List components Mar 22, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 22, 2017
@cagataycivici cagataycivici added this to the 4.0.RC2 milestone Mar 22, 2017
@cagataycivici cagataycivici reopened this Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

1 participant