-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve overflow hidden on DataTable #2447
Comments
I would like to know what problem is solved by hiding overflow. I just don't see it. |
"overflow:hidden" is causing problems (first picture). If I change it to "overflow:visible" the dropdown is visible as expected (second picture). After posting tjhis comment I found another github issue with workaround #2368 |
So the question remains: why is "overflow:hidden" the default style? It causes many problems and appears to solve none. |
Seems like that style is for everything I need to use. Kind of interesting considering later on in the template you have something like this going on for a ui-dropdown-panel class. z-index: 1001? hmmm....what's going on here? |
I'll rethink this for 4.1.0 final, it is only necessary for resizable columns and body of scrollable table, for other cases we can avoid it. Also overlay components have appendTo="body" to avoid this. |
Pulling components out of their parent node and appending them to the document root is a lazy workaround for something that can be solved with CSS only. I'm not very knowledgeable about accessibility but I can imagine that moving elements around the DOM like that makes web apps unusable to people who rely on screen readers and such. |
We have a need to display a filter dropdown from the header of a table while using resizeble columns and a scrollable table. Hoping this usage can also be handled in the next version. |
@StevenLiekens I see that as a nice addon to enhance flexibility, so that you can customize the component. About overflow, we definitely need scrollable body to be auto to get the scrollbar, for scrollheader header and footer, it has to be hidden so that we can avoid display scrollbar for them. For regular cells, it makes sense for only resizable columns to be overflow hidden, I'll do this change. |
I upgraded to 4.2.1 and the problem seems to still persist... appendTo="body" is still the only solution that I can tell. |
Every DataTable cell hides its overflow by default. Is this really necessary? What kind of content would cause cells to overflow in a bad way?
Same question for the header part of a scrollable table:
Why would you always want to hide overflow?
I'm asking because I keep running into situations where I need to display controls inside cells that should flow over the cell borders of the DataTable, such as drop-down lists and calendars . The default styling makes this more difficult than it should be.
The text was updated successfully, but these errors were encountered: