Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable, findNextEditableColumn throws exception when using tab from the last cell in the grid #2615

Closed
dschmitz-gsits opened this issue Apr 26, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dschmitz-gsits
Copy link

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

http://plnkr.co/edit/f4yYapk4PQoUEL4VXu6V

Current behavior
If you select the cell with the value "2018" in the plnkr above and hit the "tab"-key you will observe this error:

Cannot read property 'classList' of null"

Expected behavior
No exception should be thrown if there is no next cell available.

A simple resolution should be to just add the following at this point:
https://github.com/primefaces/primeng/blob/master/components/datatable/datatable.ts#L1604

... } else { return; }

  • PrimeNG version: primeng@4.0.0-rc.3
@cagataycivici cagataycivici self-assigned this Apr 28, 2017
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 28, 2017
@cagataycivici cagataycivici added this to the 4.0.0 milestone Apr 28, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants