-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataTable sorting broken when using pagination #2618
Comments
This is weird because I am using the same version in my current app I am developing and the sorting works fine. Also see this plnkr I made yesterday to show a different issue I am having. Sorting is working just fine there. http://plnkr.co/edit/gZGid81oodPX8RwRC4bm The strange thing is that in your plnkr, in which I presume you used the template just as I had, I am able to reproduce the issue you describe. I took your example and added more rows so that paging actually has something to do to see if that was the issue, but it was not. However, If you now click on the header to sort and then choose one of the other pages the table will then be sorted by the column you clicked on. http://plnkr.co/edit/lpwwylWn87nKPXqmrqXD |
The problem is with the paginator option. Setting it to true causes the issue I am experiencing. |
I'm sorry I included the wrong plnk in the first link. I didn't give you the forked version with paginator set to true. Try this one http://plnkr.co/edit/JizxgHpxAdNp6wnT53XS You cannot see the paging which is an affect of the other bug I made the original plnk about, but sorting is working as expected. |
After some digging I finally agve in and just ran a diff on our two examples and found I had When I change to rc4 then I too experience the same sorting problems. I also tested **rc.2 and rc.**3 and both seem to be working as expected as well. So it appears that rc4 is when sorting has broken. |
Try RC5 please. |
Functioned perfectly, RC5 Angular 4.0.3 |
Looks to here. Thanks for the quick fix @cagataycivici |
Hi @cagataycivici , @bmstambaugh still I see the issue, if paginator=true, sorting is broken, can you please let me know if this is fixed in latest primeng release? |
I'm submitting a ... (check one with "x")
Plunkr Case (Bug Reports)
http://plnkr.co/edit/3eU5m4mrjVPWnPTfVGDt
Current behavior
The entries in the table are not sorted.
Expected behavior
The entries in the table should be sorted.
Minimal reproduction of the problem with instructions
Create a DataTable that is not lazy loaded and uses pagination.
Angular version:
4.0.2
PrimeNG version:
PrimeNG 4.0.0-RC2 - PrimeNG 4.0.0-RC4
Browser:
Chrome, Firefox
The text was updated successfully, but these errors were encountered: