Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectButton onFocus throws error on Firefox #2801

Closed
SchneMa opened this issue May 17, 2017 · 3 comments
Closed

SelectButton onFocus throws error on Firefox #2801

SchneMa opened this issue May 17, 2017 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@SchneMa
Copy link

SchneMa commented May 17, 2017

[x ] bug report => Search github for a similar issue or PR before submitting

Plunkr Case (Bug Reports)
instead of a Plunker:
https://www.primefaces.org/primeng/#/selectbutton

Current behavior
If you click the selectButton an Error occures as you can see in the console.
It seems like the button is still working after that. (I found now advice that something is not working like it should after the Error was thrown/logged).

ReferenceError: event is not defined
It seems like the Error occures in the onFocus event.
Error is shown even when that event is not used.

Tested in Firefox and Chrome
The Error occures in Firefox but not in Chrome.

Minimal reproduction of the problem with instructions
Go to the showcase Page (link above) and click on a selectButton while whatching to the console.

  • PrimeNG version: Tested on 4.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    FF

@andrush001
Copy link

andrush001 commented May 24, 2017

In selectbutton.ts there is a missing parameter:

primngbug

@cagataycivici cagataycivici self-assigned this May 27, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 27, 2017
@cagataycivici cagataycivici added this to the 4.0.2 milestone May 27, 2017
@cagataycivici cagataycivici changed the title p-selectButton onFocus "ReferenceError" in Firefox SelectButton onFocus throws error on Firefox May 27, 2017
@andrush001
Copy link

It looks like there is a typo in your fix @cagataycivici

@sudheerj
Copy link
Contributor

It was fixed in a new commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants