Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown breaks editable datatable layout on Firefox #2907

Closed
NIX-Pepe opened this issue May 28, 2017 · 0 comments
Closed

Dropdown breaks editable datatable layout on Firefox #2907

NIX-Pepe opened this issue May 28, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@NIX-Pepe
Copy link

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
If primeng editable table demo is opened in FF 45 (https://www.primefaces.org/primeng/#/datatable/editable) you can see that there are added multiple empty columns right of sale date column. There will be more empty columns added to right side of sale date, if there are more rows.
Note, that this behavior only occurs, if there is more than one additional column right to brand column containing a drop down menu. It does not occur if there is no drop down or only one column after a column comprising a drop down menu. Additionally it only seems to happen in FF. If I open demo site in chromium there are no empty columns. All columns specified are expanded to full width of table.

Expected behavior
Same as in chromium, no empty columns added by adding additional rows. All columns expanded to full width of table.

Minimal reproduction of the problem with instructions
Step 1: Open demo in FF 45: https://www.primefaces.org/primeng/#/datatable/editable
Step 2: Open demo in Chromium/Chrome: https://www.primefaces.org/primeng/#/datatable/editable

What is the motivation / use case for changing the behavior?
It is weird for an enduser to see tables shrinking by adding new rows to them.

Please tell us about your environment:
FF 45, Debian Strech, angular-cli/ng serve...

  • Angular version:
    Angular 4

  • PrimeNG version:
    primeng@4.0.0

  • Browser:
    Chrome 58.0.3029.81
    Firefox 45.9.0

  • Language: TypeScript:
    tsc --version
    Version 2.2.1

  • Node (for AoT issues): node --version =
    node --version
    v7.0.0

@NIX-Pepe NIX-Pepe changed the title p-datatable does not expand columns on full with of table when dropdown is added for edit (FF only, version 45.9.0) p-datatable does not expand columns to full with of table when dropdown is added for edit (FF only, version 45.9.0) May 28, 2017
@cagataycivici cagataycivici self-assigned this May 29, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 29, 2017
@cagataycivici cagataycivici added this to the 4.0.2 milestone May 29, 2017
@cagataycivici cagataycivici changed the title p-datatable does not expand columns to full with of table when dropdown is added for edit (FF only, version 45.9.0) Dropdown breaks editable datatable layout on Firefox May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants