Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a DataTable with resizableColumns and scrollable may cause unresponsive web page or lag css animation. #3195

Closed
mix5003 opened this issue Jun 23, 2017 · 1 comment · Fixed by #3233
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mix5003
Copy link
Contributor

mix5003 commented Jun 23, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/XRn8ECiOCeVOQB2g85Ni?p=preview
animation will lag when move mouse.

Current behavior
When use resizableColumns with scrollable table. when mouse move it call calculateScrollbarWidth and make DOM change every times. so it may cause unresponsive web page.

Expected behavior
I don't know. may be cache a calculateScrollbarWidth result. so it not touch a DOM.

Minimal reproduction of the problem with instructions
Use a DataTable with resizableColumns and scrollable
(only resizableColumns can make a little laggy but when use with scollable i think it significant drop performance)

Please tell us about your environment:

  • Angular version: 4.1.2

  • PrimeNG version: 4.0.3

  • Browser: all (up to cpu power)

  • Language: TypeScript 2.3.2

  • Node (for AoT issues): node --version = v7.7.4

@mix5003 mix5003 changed the title Use a DataTable with resizableColumns and scrollable may cause unresponsive web page. Use a DataTable with resizableColumns and scrollable may cause unresponsive web page or lag css animation. Jun 28, 2017
@cagataycivici cagataycivici self-assigned this Jun 28, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 28, 2017
@cagataycivici cagataycivici added this to the 4.1.0-RC3 milestone Jun 28, 2017
@cagataycivici
Copy link
Member

Fixed via PR, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants