Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockUI is not properly destroyed #3410

Closed
Axel-Latour opened this issue Jul 17, 2017 · 0 comments
Closed

BlockUI is not properly destroyed #3410

Axel-Latour opened this issue Jul 17, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Axel-Latour
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
I'm trying to use the BlockUI component on a page. I've made a test :

  • Add a BlockUI on a page, and set the "blocked" property to true. Don't set the target.
  • When you go on that page, the component is displayed, the page is blocked.
  • If you still want to access the menu of your application when a page is blocked, it's impossible. If you click on an element of the menu, the route changes, and the BlockUI component is still displayed. You can't access anymore to the BlockUI component and its "blocked" property.

For example, on the PrimeNG showcase :

  • Set z-index property of the div with id #layout-sidebar to 1007 (the value must be superior to 1006)
  • Change the route with the menu
  • The BlockUI component is still present and you can't hide it anymore...

Expected behavior

When I change route, the BlockUI should disappear. It seems that it's currently added to the body of the page, when target is undefined. Maybe add it to the current component, so when the user changes route, the component is destroyed and the BlockUI too ?

@cagataycivici cagataycivici self-assigned this Aug 23, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 23, 2017
@cagataycivici cagataycivici added this to the 4.1.4 milestone Aug 23, 2017
@cagataycivici cagataycivici changed the title Hide a BlockUI when route changes Destroy BlockUI on route change Aug 23, 2017
@cagataycivici cagataycivici changed the title Destroy BlockUI on route change BlockUI is not properly destroyed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants