Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable Loading Status Icon not working #3457

Closed
mrbalcos opened this issue Jul 20, 2017 · 2 comments
Closed

DataTable Loading Status Icon not working #3457

mrbalcos opened this issue Jul 20, 2017 · 2 comments
Assignees
@Mrtcndkn
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.1.2

Comments

@mrbalcos
Copy link

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting

Current behavior
Loading Icon does not display while data is loaded on DataTable

Expected behavior
Loading Icon should be displayed while the model assigned for Loading is set to True

Please tell us about your environment:
Windows 7

  • Angular version: 2.0.X
    Angular 4

  • PrimeNG version: 2.0.X
    PrimeNG 4.1.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

All Browsers
@mrbalcos mrbalcos changed the title DataTable Loading not working on (4.1.1), worked fine on (4.1.0) DataTable Loading Status Icon not working on (4.1.1), worked fine on (4.1.0) Jul 20, 2017
@mseemann
Copy link

the laodingIcon porperty is dfined at pScrollableView but is used in p-dataTable. so

<i [class]="'fa fa-spin fa-2x ' + loadingIcon"></i>

will result in <i class="'fa fa-spin fa-2x undefined "></i>

@Mrtcndkn Mrtcndkn self-assigned this Jul 24, 2017
@Mrtcndkn Mrtcndkn added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 24, 2017
@miniplus miniplus mentioned this issue Jul 24, 2017
Merged
@miniplus
Copy link
Contributor

miniplus commented Jul 24, 2017 •
edited
Loading

I made the PR for that previously, so I'm to blame here. Sorry people!
Already made a PR with a fix @Mrtcndkn.

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jul 25, 2017
@cagataycivici cagataycivici added this to the 4.1.2 milestone Jul 25, 2017
@cagataycivici cagataycivici changed the title DataTable Loading Status Icon not working on (4.1.1), worked fine on (4.1.0) DataTable Loading Status Icon not working Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mrtcndkn Mrtcndkn

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.1.2
Development

No branches or pull requests
5 participants
@mseemann @cagataycivici @miniplus @Mrtcndkn @mrbalcos