Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable Performance Optimizations #3468

Closed
cagataycivici opened this issue Jul 20, 2017 · 4 comments
Closed

DataTable Performance Optimizations #3468

cagataycivici opened this issue Jul 20, 2017 · 4 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Jul 20, 2017

DataTable requires optimizations as large number of rows slows it down and causes lags. Check which events trigger unnecessary change detection and reimplement them with NGZone, runOutsideAngular approach to avoid unnecessary change detection. Room for improvements are;

  • Resizable columns document mouse move listener
  • Scrollable table scroll listener
  • Editable document click listener binding
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 20, 2017
@cagataycivici cagataycivici added this to the 4.1.2 milestone Jul 20, 2017
@cagataycivici cagataycivici self-assigned this Jul 20, 2017
@cagataycivici
Copy link
Member Author

Changes are in, performance gain is significant, lags are gone.

@ova2
Copy link

ova2 commented Jul 27, 2017

Congrats. Good catch with runOutsideAngular. It's also used with Analytic Scripts, etc.

@steefzuid2
Copy link

Hey,

What about the actual commits that should acompany this ticket? I don't see any commits, I don't see any performance improvements either?

@steefzuid2
Copy link

Ahh, I found the commits!. But if I use a datatable in my application I see a doCheck event on the component for every mouse move, even outside the component. I would expect that the checks do not popup since the document.onmousemove is running outside angular?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants