Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error: dropdown.d.ts.Dropdown.html (6,13): Type 'string' is not assignable to type 'boolean'. #3781

Closed
danny-swimmer opened this issue Aug 29, 2017 · 39 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@danny-swimmer
Copy link

[x ] bug report => Search github for a similar issue or PR before submitting

Current behavior
After upgrading primeng from 4.1.3 to 4.2.0-rc.1, I get this build error in my Angular.io project:
ERROR in ng:.../web/ewp/objs/node_modules/primeng/components/dropdown/dropdown.d.ts.Dropdown.html (6,13): Type 'string' is not assignable to type 'boolean'.

Expected behavior
Should build without errors

Please tell us about your environment:
Linux
Angular.io with angular-cli

Here is my package.json file:
{ "name": "d3", "version": "0.0.0", "license": "MIT", "scripts": { "start": "ng serve", "lint": "tslint \"src/**/*.ts\"", "test": "ng test", "pree2e": "webdriver-manager update", "e2e": "protractor" }, "private": true, "//": "#################################################################################################################################", "//": "Comments go here", "//": "#################################################################################################################################", "dependencies": { "@angular/cli": "1.3.2", "@angular/common": "4.3.6", "@angular/animations": "4.3.6", "@angular/compiler": "4.3.6", "@angular/compiler-cli":"4.3.6", "@angular/core": "4.3.6", "@angular/forms": "4.3.6", "@angular/http": "4.3.6", "@angular/platform-browser": "4.3.6", "@angular/platform-browser-dynamic": "4.3.6", "@angular/router": "4.3.6", "@angular/material": "2.0.0-beta.8", "@angular/cdk": "2.0.0-beta.8", "@types/hammerjs": "2.0.35", "hammerjs": "2.0.8", "core-js": "2.5.0", "primeng": "4.2.0-rc.1", "rxjs": "5.4.3", "ts-helpers": "1.1.2", "zone.js": "0.8.17" }, "devDependencies": { "@types/jasmine": "2.5.54", "@types/node": "8.0.25", "@types/chrome": "0.0.48", "angular2-template-loader": "0.6.2", "codelyzer": "3.1.2", "jasmine-core": "2.8.0", "jasmine-spec-reporter": "4.2.1", "karma": "1.7.0", "karma-chrome-launcher": "2.2.0", "karma-cli": "1.0.1", "karma-jasmine": "1.1.0", "karma-remap-istanbul": "0.6.0", "protractor": "5.1.2", "ts-node": "3.3.0", "tslint": "5.7.0", "typescript": "2.2", "webdriver-manager": "12.0.6" } }

  • Angular version: 2.0.X
    4.3.6

  • PrimeNG version: 2.0.X
    4.2.0-rc.1

@dockleryxk
Copy link

dockleryxk commented Aug 29, 2017

I'm pretty sure this commit fixed it, but didn't reference this issue

@sgomanf
Copy link

sgomanf commented Aug 29, 2017

same issue

1 similar comment
@xiongyayun428
Copy link

same issue

@huineng
Copy link

huineng commented Aug 30, 2017

commit didn't fix #3780

@harikrishnan-u01
Copy link

Am facing this issue in "primeng": "4.2.0-rc.1",

@sonnh58
Copy link

sonnh58 commented Aug 31, 2017

same issue in "primeng": "4.2.0-rc.1",

@Ketec
Copy link

Ketec commented Aug 31, 2017

Confirmed, this issue exists in aot build.

@upstreamosGH
Copy link

Same issue on aot after update primeng to v4.2.0-rc1

@mtschaffler
Copy link

I am having the same issue as well :-) - What would be the latest primeng release where AOT works fine?

@mtibbo
Copy link

mtibbo commented Aug 31, 2017

Same issue here too, after update primeng to 4.2.0-rc.1

@jiazijing-zte
Copy link

same issue

@dockleryxk
Copy link

dockleryxk commented Aug 31, 2017

Commenting that you have the same issue really only clogs up the thread. Unless you have something constructive to say or a question, just thumbs up the issue.

@jesusce21
Copy link

Is there any temp solution to build without errors?

@shalugin
Copy link

shalugin commented Sep 1, 2017

@jesusce21 revert to 4.1.3 ?

@rodrigoauglima
Copy link

Same problem here. Reverting to 4.1.

@LucasBrazi06
Copy link

I just reverted to 4.1.3 and it built successfully.

@SpiderPork
Copy link

Same

@wlclass
Copy link

wlclass commented Sep 5, 2017

same issue

@kravda
Copy link

kravda commented Sep 5, 2017

+1

@TheWrightDev
Copy link
Contributor

@cagataycivici - It looks like the fix for this has been in place for over a week. Any plans for a release in the near future so we can build again?

@ratbeard
Copy link

ratbeard commented Sep 6, 2017

THIS ISSUE IS ALSO AFFECTING ME!!!

@akisvolanis
Copy link

Any plans for releasing v4.2.0-rc2, fixing this issue?

@avarndell
Copy link

I'm having the same issue

@faizalmy
Copy link

faizalmy commented Sep 8, 2017

+1

@cyberrranger
Copy link

same problem

@lafourmirouge
Copy link

Same issue

@dylandechant
Copy link

same here

@stevenxi
Copy link

stevenxi commented Sep 8, 2017

Same here +1.

Thanks.

@BigBaBei
Copy link

BigBaBei commented Sep 9, 2017

+1

@eminoda
Copy link

eminoda commented Sep 9, 2017

+1 in 4.2.0-rc.1,when run ‘--prod’。
but 4.1.3,it works good。

@saskyagurgel
Copy link

+1

@saskyagurgel
Copy link

I fixed replacing *ngIf="!editable&&label" to *ngIf="!editable&&!!label"

@sebichondo
Copy link

Thanks @eminoda downgrading to 4.1.3 worked for me too

@adityals
Copy link

@saskyagurgel can you post your file or tell us the file location to put this code? By the way, if I downgrade to 4.1.3 I can't use the MessageService class. Please help me.

@saskyagurgel
Copy link

@adityals i'm changed the file ...\node_modules\primeng\components\dropdown\dropdown.metadata.json
replacing *ngIf="!editable&&label" to *ngIf="!editable&&!!label"

@correasebastian
Copy link

+1

@cagataycivici cagataycivici self-assigned this Sep 13, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 13, 2017
@cagataycivici cagataycivici added this to the 4.2 milestone Sep 13, 2017
@cagataycivici
Copy link
Member

Fixed for 4.2.0 already.

@cagataycivici
Copy link
Member

4.2.0 is released now, please try with this one.

@patriknil90
Copy link

patriknil90 commented Sep 13, 2017

No build error now (with 4.2.0)! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests