Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete forceSelection should be caseSensitive #3932

Closed
huineng opened this issue Sep 13, 2017 · 2 comments
Closed

AutoComplete forceSelection should be caseSensitive #3932

huineng opened this issue Sep 13, 2017 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@huineng
Copy link

huineng commented Sep 13, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
  • PrimeNG version: 2.4.2
    Is there any particular reason why you decided not to enforce strict equality for forceselection

I think this is not the right solution
if i type in "germany" and the drop down value id "Germany" then this should be cleared, not allowed

Many of us have back end systems that verify on equality and now it's still possible to enter
... fRaNcE and the value will not be cleared

thanks

if(itemValue && inputValue === itemValue.toLowerCase()) {
                        valid = true;
                        break;
                    }
@huineng huineng changed the title force selection is case insensitive forceSelection is case insensitive Sep 14, 2017
@huineng
Copy link
Author

huineng commented Oct 4, 2017

one solution is to add an addition option eg .. forceselection : true / false / strict
if strict don't do lowercase comparison but strict comparison

as i said hight fRaNcE will remain in the input box even if i didn't select France from the drop down list

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 20, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 20, 2017
@cagataycivici cagataycivici self-assigned this Oct 20, 2017
@cagataycivici cagataycivici changed the title forceSelection is case insensitive Add caseSensitiveForceSelection to AutoComplete Oct 20, 2017
@cagataycivici cagataycivici changed the title Add caseSensitiveForceSelection to AutoComplete AutoComplete forceSelection should be caseSensitive Oct 23, 2017
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 23, 2017
@huineng
Copy link
Author

huineng commented Oct 23, 2017

great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants