Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Confirm Dialog event performance #4085

Closed
cagataycivici opened this issue Oct 3, 2017 · 0 comments
Closed

Improve Confirm Dialog event performance #4085

cagataycivici opened this issue Oct 3, 2017 · 0 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.2.2

Comments

@cagataycivici
Copy link
Member

Only bind escape listener when dialog is being shown and unbind it on close, also use NgZone runOutSide angular for resize listener.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 3, 2017
@cagataycivici cagataycivici added this to the 4.2.2 milestone Oct 3, 2017
@cagataycivici cagataycivici self-assigned this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
4.2.2
Development

No branches or pull requests
1 participant
@cagataycivici