Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu adds space when there is no icon #4156

Closed
filipvh opened this issue Oct 12, 2017 · 0 comments
Closed

TabMenu adds space when there is no icon #4156

filipvh opened this issue Oct 12, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@filipvh
Copy link

filipvh commented Oct 12, 2017

[x] bug report
[ ] feature request
[ ] support request

Current behavior
primeng/src/app/components/tabmenu/tabmenu.ts
if there is no icon defined
the label is not in center
this should not be

image

Expected behavior
No icon -> no space on the left side of the label

Minimal reproduction of the problem with instructions
Make TabMenu Tab without icon defined

What is the motivation / use case for changing the behavior?
Normal Usage

  • Angular version: 4.2.4
  • PrimeNG version: 4.2.1
  • Browser: [ Chrome (tested) ]
  • Language:[all]
@cagataycivici cagataycivici self-assigned this Oct 19, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 19, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 19, 2017
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 19, 2017
@cagataycivici cagataycivici changed the title tabmenu space - easly fixed TabMenu adds space when there is no icon Oct 24, 2017
@cagataycivici cagataycivici added confirmed and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants