Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obselete property on .ui-datatable-scrollable-wrapper #4213

Closed
nate-knight opened this issue Oct 19, 2017 · 1 comment
Closed

Remove obselete property on .ui-datatable-scrollable-wrapper #4213

nate-knight opened this issue Oct 19, 2017 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@nate-knight
Copy link

There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

http://plnkr.co/edit/6q5v84DWolH6DeAdi70w?p=preview

Current behavior
Non-existing 'max-height' class is getting applied to scrollable tables on the .ui-datatable-scrollable-wrapper node.

Expected behavior
.ui-datatable-scrollable-wrapper should not have 'max-height' applied as a class to .ui-datatable-scrollable-wrapper. The style 'max-height' is already being applied to another element, .ui-datatable-scrollable-body, which is correct.

Minimal reproduction of the problem with instructions
See 'max-height' class getting applied to .ui-datatable-scrollable-wrapper node:
http://embed.plnkr.co/coNQlXE9NVgonQHf2urP/

What is the motivation / use case for changing the behavior?
To clean up superfluous code that may cause confusion.

Please tell us about your environment:

  • Angular version: 2.0.X
  • PrimeNG version: 2.0.X
    4.2.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 20, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 20, 2017
@cagataycivici cagataycivici self-assigned this Oct 20, 2017
@cagataycivici
Copy link
Member

Fixed via PR

@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 24, 2017
@cagataycivici cagataycivici changed the title Remove incorrect [ngClass] property on .ui-datatable-scrollable-wrapper Remove obselete property on .ui-datatable-scrollable-wrapper Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants