Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with overlaypanel in 4.3.0 #4327

Closed
dhniels opened this issue Oct 31, 2017 · 11 comments
Closed

Bug with overlaypanel in 4.3.0 #4327

dhniels opened this issue Oct 31, 2017 · 11 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dhniels
Copy link

dhniels commented Oct 31, 2017

I have a delete confirmation overlaypanel that appears when clicking an "X" icon in my app. it is inside a p-dialog component if that matters...

after updating to primeNG 4.3.0 the overlaypanel no longer appears. Upon inspection, it appears that it is not toggling display: none to display: block as it normally should. Are you able to reproduce?

@cagataycivici cagataycivici self-assigned this Nov 6, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 6, 2017
@cagataycivici cagataycivici added this to the 4.3.1 milestone Nov 6, 2017
@cagataycivici
Copy link
Member

Unable to replicate, please provide a test case based on plunkr below and we'll review again.

http://plnkr.co/edit/6q5v84DWolH6DeAdi70w?p=info

@cagataycivici cagataycivici removed this from the 4.3.1 milestone Nov 6, 2017
@mronus
Copy link

mronus commented Nov 6, 2017

@cagataycivici - We've the same issue with p-overlayPanel. It happens only for some of components on our application, especially when not using appendTo. I couldn't reproduce this on components other than broken ones yet, but I can see that it gets fixed when adding appendTo to the broken components.

I had to apply a workaround like the following to come over this issue.

<button (click)="togglePanel($event)">Test</button>
function togglePanel(event: any) {
  this.overlayPanel.toggle(event);
  this.overlayPanel.el.nativeElement.classList.toggle('menu-open');
}
.menu-open {
  display: block !important;
}

@richteri
Copy link

richteri commented Nov 6, 2017

We also have this issue, I'll try to create a plnkr for it.

@dhniels
Copy link
Author

dhniels commented Nov 10, 2017

@mronus I'm having the exact same behavior as yours. Applying appendTo body fixes it, as does your fix. Definitely a bug introduced in 4.3.0 somewhere.

@dhniels
Copy link
Author

dhniels commented Nov 27, 2017

Still have this bug in PrimeNG 5. updated to 5.0.2 and the issue persists. I tried recreating the bug in plunker but have been unsuccessful. There is certainly something going on in my app, if Prime is willing to reach out to me and address this issue, I'd be happy to screenshare.

@dhniels
Copy link
Author

dhniels commented Nov 27, 2017

@cagataycivici please re-open this issue.

i was finally able to create a working example of the bug. See the Plunker.

It appears that if the overlaypanel has position:fixed it breaks the toggle between display: none and display: block, or at least, I think this is the culprit, because if I change it to position: absolute, it then works correctly. Please investigate.

@rikan
Copy link

rikan commented Nov 30, 2017

the same issue
in 4.2 this code can show overlayPanel.
this.overlayPanel.show(null, this.contentRef.nativeElement)
but in 4.3.0 it not working,
even give click event parameter, the overlayPanel is still display:none.

@dhniels
Copy link
Author

dhniels commented Dec 1, 2017

no response in a over a month on this issue. sometimes i wonder if the primeNG team just cherrypicks issues and closes ones they dont want to deal with because there is broken functionality all over the place that is completely unaddressed. When I create issues they are immediately closed and never looked at again 50% of the time. Im beginning to regret my choice using PrimeNG in my application. if this is the way they run their product I certainly will be staying away from the Pro upgrade, which I had strongly considered until recently. I don't mean to sound ungrateful as they are doing a valuable service, I am just incredibly disappointed what feels like complete disinterest in handling bugs for their users.

@dhniels
Copy link
Author

dhniels commented Apr 16, 2018

I'm still having this issue in PrimeNG 5.2.4... 6 months later.... For what its worth I tested with both Chrome and Firefox, and I could only replicate it in Chrome. Same applies for the plunker i created above.

@cagataycivici cagataycivici added this to the 5.2.5 milestone Apr 16, 2018
@cagataycivici
Copy link
Member

Set to review for 5.2.5

@acarboni71
Copy link

PrimeNG 5.2.7 still has this problem. Please, help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants