Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chips component onFocus & onBlur events do not pass arguments to callback function #4436

Closed
KeithGillette opened this issue Nov 14, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@KeithGillette
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The Chips component recently got onBlur & onFocus events, which, according to the documentation, are both supposed to pass originalEvent: Browser event to the provided callback method.

However, both the onBlur & onFocus events in the Chips component pass nothing to the callback method, so its parameter values are undefined.

Expected behavior
The onFocus and onBlur events would pass the original FocusEvent to the provided callback method, per the documentation.

Better yet, the onFocus & onBlur events would pass any arbitrary arguments passed to the provided callback method.

Minimal reproduction of the problem with instructions
http://plnkr.co/edit/Rnv7IKmqh98ntpDnY2H9?p=preview

What is the motivation / use case for changing the behavior?

  • Conform to documentation.
  • Easily allow server save of value onBlur rather than onAdd & onRemove.
@cagataycivici cagataycivici self-assigned this Nov 17, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 17, 2017
@cagataycivici cagataycivici added this to the 5.0 milestone Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants