Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-header of Custom legend fails #4470

Closed
aamir1995 opened this issue Nov 17, 2017 · 3 comments
Closed

p-header of Custom legend fails #4470

aamir1995 opened this issue Nov 17, 2017 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@aamir1995
Copy link

aamir1995 commented Nov 17, 2017

There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

Custom Legend for Fieldset is not working in latest 5.0.0-rc.0, If we set toggleable to True it works fine, also it seems to be work fine in previous releases
plnkr for previous release: http://plnkr.co/edit/RgG5Znx63nFC252aysat?p=preview
This issue might be introduced during this commit d325a9d

Expected behavior

The custom legend should work as expected in the latest release.

Minimal reproduction of the problem with instructions

Starter Plunker is not updated to the latest release 5.0.0, so I am posting a screenshot here.
image

What is the motivation/use case for changing the behavior?

Please tell us about your environment:

Windows 10
Visual studio code
NPM 5.5.1

  • Angular version: 2.0.X

Angular 5

  • PrimeNG version: 2.0.X

PrimeNG 5.0.0-rc.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

ALL

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@rkdvep
Copy link

rkdvep commented Nov 17, 2017

custom legend can be included with the 'legend' tag, instead of a header element. can you try that? View source for example: https://www.primefaces.org/primeng/#/fieldset

@aamir1995
Copy link
Author

aamir1995 commented Nov 17, 2017

@rkdvep I'm talking about <p-header>Custom Legend Content</p-header> legend. I have updated the title, the previous one was a bit confusing I guess.

@aamir1995 aamir1995 changed the title Custom legend broken in 5.0.0-rc.0 p-header of Custom legend broken in 5.0.0-rc.0 Nov 17, 2017
@sudheerj
Copy link
Contributor

I can replicate the issue. It's an issue with multiple ng-content tags used in this place. Because is for static projection but not for dynamic.

angular/angular#9173

@sudheerj sudheerj added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 20, 2017
@cagataycivici cagataycivici changed the title p-header of Custom legend broken in 5.0.0-rc.0 p-header of Custom legend fails Nov 23, 2017
@cagataycivici cagataycivici self-assigned this Nov 23, 2017
@cagataycivici cagataycivici added this to the 5.0.1 milestone Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants