Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectButton does not support OnPush ChangeDetection #4520

Closed
hanouard opened this issue Nov 23, 2017 · 1 comment
Closed

SelectButton does not support OnPush ChangeDetection #4520

hanouard opened this issue Nov 23, 2017 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@hanouard
Copy link

I'm submitting a ... (check one with "x")

[ X ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Im using p-selectButton in a component that have OnPush detection strategy.

On component init, i update the options and the selected value with data fetched via rest web service.

After manually marking the component for check: this.changeDetectorRef.markForCheck(), the options are updated but not the selected value.

Plunkr Case (Bug Reports)
http://plnkr.co/edit/1Dqj1sZWPmIGWKu9FNm5?p=preview

Im using angular 4.0.x with primeNG 4.3.0

@cagataycivici cagataycivici self-assigned this Dec 18, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 18, 2017
@cagataycivici cagataycivici added this to the 5.1.0-M1 milestone Dec 18, 2017
@cagataycivici cagataycivici added confirmed and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 25, 2017
@cagataycivici cagataycivici changed the title selectButton selectedValue not updated with OnPush detection strategy SelectButton does not support OnPush ChangeDetection Dec 25, 2017
@pdhamija
Copy link

Hello cagataycivici,
We are using Angular 4.3.x and primeNg 4.2.x. We really need this fix. But it seems that you have added this in 5.1.x? To use that version, we will have to move to Angular 5, which we cannot, since we have other compatibility issues and restrictions.
Can you please also put this fix in a primeNg version (4.x) that works with Angular 4. Please!
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants