Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Table Component aka TurboTable #4743

Closed
cagataycivici opened this issue Dec 29, 2017 · 17 comments
Closed

New Table Component aka TurboTable #4743

cagataycivici opened this issue Dec 29, 2017 · 17 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Dec 29, 2017

Create a template driven new table component to succeed p-dataTable. New p-table is designed to be lightning fast compared to p-dataTable and much more flexible.

@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Dec 29, 2017
@cagataycivici cagataycivici added this to the 5.1.0-RC1 milestone Dec 29, 2017
@cagataycivici cagataycivici self-assigned this Dec 29, 2017
@jisqaqov
Copy link

I think a very good feature should also be rowspan and colspan for rows. Currently available only for headers. Is it in a plan?

@cagataycivici
Copy link
Member Author

@jisqaqov p-table has a template driven approach so it is easy to implement this on your side since you have full control over markup, we'll add a demo as well as a sample.

@jisqaqov
Copy link

jisqaqov commented Jan 5, 2018

It should be considered that rows can have columns with multiple number of rowspan and cospan attributes.

@jisqaqov
Copy link

jisqaqov commented Jan 5, 2018

I guess currently you support rowgouping by only one column, but it is not enough. It should support any number of rowspan and colspan

@cagataycivici
Copy link
Member Author

We've added a demo, it is up to you how you implement it, new TurboTable does not limit this like the old one.

@pantonis
Copy link
Contributor

pantonis commented Jan 9, 2018

@cagataycivici In order to use this table do we need to migrate from the old datatable?

@pantonis
Copy link
Contributor

pantonis commented Jan 9, 2018

Downloaded latest code from master and while clicking on table I get

ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'table'
Error: Cannot match any routes. URL Segment: 'table'

Adding the following in src/app/showcase/app-routing.module.ts solves the problem

{path: 'table', loadChildren: './components/table/tabledemo.module#TableDemoModule'},

@cagataycivici
Copy link
Member Author

cagataycivici commented Jan 10, 2018

No you don't, old one is p-dataTable, new one is p-table. It is being documented now to be released next week. The route seems to be missing yes, we'll add it. Note that TurboTable is beta and will be prod ready in 5.2 release due mid february.

@nsksaisaravana
Copy link

Awesome guys, please add features like ag-grid.

@Ketec
Copy link

Ketec commented Jan 15, 2018

How much backwards compatibility will it have with old table? Since we use it around 9 different places, would they all have to be fully redesigned, different properties and setup logic or can old tables be migrated with some adjustments (keeping col definitions, templates, event handlers etc)?

Also will it have a kind of click event prevention option (based of some condition, cancel selection/selection events - like onBeforeSelect or something)?

@cagataycivici
Copy link
Member Author

There is no backwards compatibility because it is a brand new component. Old one still works but will be phased out in a future release. There are similarities but also significant differences. You should be able to migrate slowly as old one still be there and looks the same as the new one.

@ghost
Copy link

ghost commented Jan 16, 2018

@cagataycivici Hi. Does the new component support all the features that DataTable has? Filtering, Sorting, Pagination, Lazy Loading?

@bbuehrer
Copy link
Contributor

The theme doesn't work for header and body.
How can i use custom-sort? i only find pSortableColumn.

@Levent0z
Copy link

Please do not phase out the old one. We've built our own functionality on it, and it would be a shame to not be able to upgrade in order not to lose dataTable.

@SteamWind
Copy link

Sad that the bootstrap theme doesn't work on this new table. It is planed to be supported?

@tavaneftekhar
Copy link

Is there any hope for a step-by-step guide to converting an old datatable to work as a new table? I have to migrate a lot of tables and want to make sure I'm not missing anything important.

@PabMendez
Copy link

PabMendez commented Apr 26, 2018

the documentation is vague, I'm trying to dynamically set the colspan and rowspan and I can not find any useful information in the demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

10 participants