Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect updateLabel fails when selectedItemsLabel does not include {} #4905

Closed
michaelplavnik opened this issue Jan 20, 2018 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@michaelplavnik
Copy link

I'm submitting a bug report.

I am not attaching plunker fork, as the issue is best demonstrated by the source code

In multiselect.ts component in updateLabel() function at line 394 code assumes presence of the {} in the value of selectedItemsLabel property (e.g. [0] on the regex matches).
Documentation does not require such presence, and requiring it prevents simple and useful use cases, e.g. displaying the same string to the user when nothing or all is selected when implementing filter parameters.

Fix is trivial, please implement it.

@bfaulk96
Copy link

bfaulk96 commented Mar 12, 2018

Experiencing the same problem. I have submitted pull request #5324 that should fix our issue.

@cagataycivici cagataycivici self-assigned this Mar 26, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 26, 2018
@cagataycivici cagataycivici added this to the 5.2.4 milestone Mar 26, 2018
@markovicboban
Copy link

This problem is still present (v5.2.6). Whenever I provide plain text to be used as selectedItemsLabel, it gets reverted to the default value ({0} selected).

@magnusjohannessen
Copy link

I am also still having this problem (v 7.1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants