Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating fails under Push change detection #4994

Closed
eugenebuhor opened this issue Jan 26, 2018 · 0 comments
Closed

Rating fails under Push change detection #4994

eugenebuhor opened this issue Jan 26, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@eugenebuhor
Copy link

eugenebuhor commented Jan 26, 2018

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/WPbR9XmbgddrrpfgIdbZ?p=preview

Current behavior
Rating input in turbo-table component works incorrect with Angular OnPush change detection strategy.

Minimal reproduction of the problem with instructions
The rating component does not work properly when embedded into p-table in AOT mode.
In the attached plunker, click on a star in the First rating column
The value would change as expected, but the rating control will not redraw itself
Click anywhere in the grid and the rating will redraw itself.

Please tell us about your environment: Window 10, Webstorm 2017.3.3

  • Angular version: 5.2.1
  • PrimeNG version: 5.2.0-rc.2
  • Browser: all
  • Language: TypeScript
  • Node (for AoT issues): node --version = v9.4.0
@eugenebuhor eugenebuhor changed the title Rating input in datatable component works incorrect with Angular OnPush change detection strategy. Rating input embedded in turbo-table component works incorrect with Angular OnPush change detection strategy. Jan 26, 2018
@cagataycivici cagataycivici changed the title Rating input embedded in turbo-table component works incorrect with Angular OnPush change detection strategy. Rating fails under Push change detection Jan 31, 2018
@cagataycivici cagataycivici self-assigned this Jan 31, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 31, 2018
@cagataycivici cagataycivici added this to the 5.2.0-RC3 milestone Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants