Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-card control's line-height style causes inconsistent heights with internal controls #5001

Closed
AlejandroFlorin opened this issue Jan 27, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@AlejandroFlorin
Copy link

AlejandroFlorin commented Jan 27, 2018

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Unfortunately the plunker project doesn't support p-card so I cannot create one

Current behavior
If you place various input controls inside a p-card, like p-dropdown, and pInputText, their heights change when compared to outside of a p-card. The cause is the p-card's .ui-card-content line-height=1.5 style. The p-dropdown especially displays differently depending on whether its editable property is true or false.

The workaround was to override the style as follows:

.ui-card-content {
line-height: normal;
}

Expected behavior
Input controls placed inside and outside of a p-card should have identical layout.

Minimal reproduction of the problem with instructions

Place a textbox, p-dropdown (editable =true) and another p-dropdown (editable=false) both inside and outside a p-card container and examine the heights

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
Windows 10, Visual Studio 2017

  • Angular version: 5.2.1
  • PrimeNG version: 5.2.0-rc.1
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    All

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    All

  • Node (for AoT issues): node --version =

@AlejandroFlorin AlejandroFlorin changed the title p-card control's line-height style causes inconsistent layout problems with internal controls p-card control's line-height style causes inconsistent heights with internal controls Jan 27, 2018
@cagataycivici cagataycivici self-assigned this Mar 27, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 27, 2018
@cagataycivici cagataycivici added this to the 5.2.4 milestone Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants