Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown with default value does not work properly with clear button #5280

Closed
rafa-suagu opened this issue Mar 7, 2018 · 9 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rafa-suagu
Copy link

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/zIEhdMlGSNzCqmhZU41h?p=preview

Current behavior
bug-dropdown

Expected behavior
Open the dropdown.

Minimal reproduction of the problem with instructions

  1. Create a dropdown with selected/default value
  2. Click clear button
  3. Try to open the dropdown

What is the motivation / use case for changing the behavior?
Obviously this error makes the dropdown unusable.

Please tell us about your environment:
OS: MAC OS X High Sierra 10.13.3
IDE: WebStorm 2018.1 EAP
Package Manager: Yarn 1.5.1
Node: 9.7.1
Angular-cli: 1.7.2

  • Angular version: 5.2.7

  • PrimeNG version: 5.2.1

  • Browser: all

  • Language: all

  • Node (for AoT issues): node --version = 9.7.1

@perkma
Copy link

perkma commented Mar 7, 2018

The clear button does not emit an onChange event. Is that an intended behavior?

@rafa-suagu
Copy link
Author

I don't know @perkma but for me is another bug

@davisb10
Copy link
Contributor

davisb10 commented Mar 7, 2018

It is performing the same way even in the demo. This needs to fixed soon as it breaks the entire dropdown and makes in unusable.

@blackholegalaxy
Copy link

Agreed. The dropdown is unusable

@nakurd
Copy link

nakurd commented Mar 7, 2018

please make it optional.

@mlangwell
Copy link

Observing the same behavior, and I agree our team needs the clear icon optional.

@jamieathans
Copy link

Workaround to hide the clear button:

Add the following in global styes.scss:

p-dropdown {
  .ui-dropdown-clear-icon {
    display: none;
  }
}

@EleanorHughes
Copy link

Any idea when this is going to be fixed? We need both the clear button and the dropdowns in our application

@cagataycivici cagataycivici changed the title Dropdown with default value does not work properly since 5.2.1 and clear button Dropdown with default value does not work properly with clear button Mar 9, 2018
@cagataycivici cagataycivici self-assigned this Mar 9, 2018
@cagataycivici cagataycivici added this to the 5.2.2 milestone Mar 9, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 9, 2018
@cagataycivici
Copy link
Member

5.2.2 is now published with this fix and others;

https://www.primefaces.org/primeng-5-2-2-released/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

9 participants