Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showClear property to Dropdown #5285

Closed
brian428 opened this issue Mar 7, 2018 · 2 comments
Closed

Add showClear property to Dropdown #5285

brian428 opened this issue Mar 7, 2018 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@brian428
Copy link
Contributor

brian428 commented Mar 7, 2018

The new clear icon for Dropdown is a nice feature, but I don't think it should just automatically be applied. We have plenty of dropdowns where a value must be chosen, so the new clear icon is confusing and also breaks our logic (before the clear icon, there was no way for the user to select "nothing").

I would say make the clear functionality opt-in via an input property. Or, less desirable would be an input property to turn it off (but that would mean we'd have to manually go through and disable it throughout our code).

@ASK83
Copy link

ASK83 commented Mar 7, 2018

I came across the similar issue (#5286) and making it optional would solve that one too.

@FirstVertex
Copy link
Contributor

FirstVertex commented Mar 8, 2018

Agree with @brian428 that this should be opt-in.

In addition, please consider adding a css class to the parent ui-dropdown whenever the clear icon is present (suggest ui-dropdown-clearable). That way my app's css can adjust, or even hide, the presentation of the clear icon based on the parent class, instead of having to target all dropdowns.

@cagataycivici cagataycivici self-assigned this Mar 9, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 9, 2018
@cagataycivici cagataycivici added this to the 5.2.2 milestone Mar 9, 2018
@cagataycivici cagataycivici changed the title Make dropdown clear functionality opt-in, or add flag to suppress Add showClear property to Dropdown Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants