Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollPanel has incorrect height setting in .ui-scrollpanel-content. #5396

Closed
Nierrrrrrr opened this issue Mar 21, 2018 · 5 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Nierrrrrrr
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request

Plunkr Case (Bug Reports)
Just go to the demo page of primeng for ScrollPanel
https://www.primefaces.org/primeng/#/scrollpanel

Current behavior
Wrong height calculate for ui-scrollpanel-content class when use the default settings.
If you don't overwrite any CSS properties when using ScrollPanel, the content height will be hidden by 18px.
The first demo don't overwrite any CSS properties and the bottom 18px of content is hidden. (The text is visible because whole content has padding: 1em;. If you remove the padding the last line of text will be truncated.)
The last demo which overwrites CSS properties to show the x-axis scrollbar doesn't suffer from this bug.

Expected behavior
Currently I'm overwriting the default CSS properties to set height from calc(100%+18px) to 100%, but it should work just fine without any overwrites to make the default settings work.

Please tell us about your environment:

  • Angular version: 5.2.9

  • PrimeNG version: 5.2.3

  • Browser: Chrome 65.0.3325.162

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 12, 2018
@cagataycivici cagataycivici added this to the 6.1.1 milestone Aug 12, 2018
@dwegzero
Copy link

dwegzero commented Aug 12, 2018

And width...

.ui-scrollpanel-content {
    height: 100%;
    width: 100%;
}

does it for now.

@mertsincan
Copy link
Member

Could you please try the following css code?

 .ui-scrollpanel-content {
   padding: 0px 18px 18px 0px; 
}

@dwegzero
Copy link

Works too.

@chrisschauer
Copy link

Hi @mertsincan,

sorry for commenting on an already closed issue, but i don't think it's fixed.

The demo pages cut's the content by 18px, but only on Firefox.
https://www.primefaces.org/primeng/#/scrollpanel

Firefox: 86.0.1

Can somebody confirm, the issue still exists on firefox?

@nchaigne
Copy link

nchaigne commented May 9, 2024

I had this issue also (primeng@17.16.0).
I had to apply the workaround discussed here to have a correct display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants