Rxjs 6 support

[markgoho-EDT]

Support Rxjs 6

[cagataycivici]

What is the problem with 6 and PrimeNG?

[markgoho-EDT]

Imports are handled differently in 6. I'm getting linting errors from the way primeng is bringing in operators and things like Observable and Subject.

[gasparbarancelli]

Angular 6 now uses the new version of Rxjs, so PrimeNG does not work with the new version of Angular, there is an error in imports.

[markgoho-EDT]

@cagataycivici some library developers are choosing to release an rxjs/angular 6 compatible version of their pacakges so people who want to upgrade can, and those who don't can stay with ng5/rxjs5

Is that something you'd be willing to entertain?

ngx-translate just did this

[cagataycivici]

I think Angular 6 uses RxJS 6, so PrimeNG 6 will use RxJS6 and PrimeNG 5 on RX5.

[markgoho-EDT]

Fantastic idea!

[gasparbarancelli]

Many thanks, looking forward to testing the new version of the Angular and PrimeNG

[markgoho-EDT]

@cagataycivici I'd like to help with updating Rxjs -- how can I submit a PR for this? I saw you made a 6.0.0 snapshot 25 days ago, but I'm not sure how to access that branch. Did you see Ben Lesh's talk at ngConf? They've got a nice package to help upgrade the project:

Here's the relevant part of the talk: https://youtu.be/JCXZhe6KsxQ?t=20m22s

Here's the repo: https://github.com/ReactiveX/rxjs-tslint

For others looking to use Rxjs/Angular 6 with PrimeNg 5, make sure you've got the rxjs-compat package installed alongside and you'll be fine.

[markgoho-EDT]

Angular 6 released today. Any ETA on this update? Again, glad to help with the upgrade process.

[gasparbarancelli]

Here is an official note of the angle that is on your blog https://blog.angular.io/version-6-of-angular-now-available-cc56b0efa7a4.

"For example, the command ng update @angular/core will update all of the Angular framework packages as well as RxJS and TypeScript, and will run any schematics available in these packages to keep you up to date. we'll automatically install rxjs-compat in your application to make the adoption of RxJS v6 smoother. "

So the version 5 of primeng would work perfectly with the Angular 6, I am already using in production without any problem.

[markgoho-EDT]

@gasparbarancelli the rxjs-compat package is meant as a temporary patch to cover any libraries that haven't updated to rxjs 6, so yes, it "works" -- but this shouldn't be seen as a solution.

NB: This issue is not to to make PrimeNG work with Angular 6, the goal here is to make it support Rxjs 6.

[rafa-suagu]

@markgoho-EDT totally agree.

[rafa-suagu]

You can check the migration steps here -> https://update.angular.io/

[gasparbarancelli]

Yes, but I just wanted to make it clear that for the moment you can run primeng with the new version of the angular without fear.

And nothing prevents you from leaving the compat dependency in your package.

[TimUnderhay]

@gasparbarancelli as a long-term solution, it's bad as it needlessly inflates the output bundle size. It really would be best to eliminate the dependency.

[Matmo10]

Looking forward to v6 - this is the last lib I use that depends on rxjs-compat :)

[unaor]

waiting as well

[hetal1110]

we are waiting as well.

[cagataycivici]

#5758