Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator causes menubar to break to new line #5741

Closed
fetherolfjd opened this issue May 16, 2018 · 2 comments
Closed

Separator causes menubar to break to new line #5741

fetherolfjd opened this issue May 16, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@fetherolfjd
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Issue #5406 exists, but is poorly written, so hopefully this will get reviewed and maybe fixed.

Stackblitz Demonstration Case (Bug Reports)

https://stackblitz.com/edit/angular-khfdcc

Current behavior
Separator inserts horizontal bar and breaks menu items after it onto a new line.

Expected behavior
Separator would insert a small vertical line between menu items.

Minimal reproduction of the problem with instructions
See above stackblitz.

What is the motivation / use case for changing the behavior?
Seems odd for a separator to throw in a horizontal line/new line? It worked as expected in PrimeNG v5.0.0, but we updated to PrimeNG v5.2.5 and saw this; though it seems to be an issue with earlier versions as well.

@nisha-kaushik
Copy link

Hey I am new to open source contributions, I wanted to pick this up. Is this issue still valid? I could get a horizontal separator. Or someone can guide me to whats needed here?

https://stackblitz.com/edit/angular-9gojmj?file=src/app/app.component.ts

@fetherolfjd
Copy link
Author

fetherolfjd commented May 17, 2018

Here's a super quick and dirty stackblitz demonstrating PrimeNG v5.0.0 with a separator in the menu bar:

https://stackblitz.com/edit/angular-2w8tiu

It's just a small vertical line that provides a little space and separation between buttons. The latest versions of PrimeNG no longer do that, and instead insert a "large", horizontal line, with all buttons after it on a new line.

@cagataycivici cagataycivici self-assigned this Dec 26, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 26, 2018
@cagataycivici cagataycivici added this to the 7.0.4 milestone Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants