Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement InputSwitch #6134

Closed
cagataycivici opened this issue Jul 23, 2018 · 9 comments
Closed

Reimplement InputSwitch #6134

cagataycivici opened this issue Jul 23, 2018 · 9 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

Modernize it using a css only approach like we did in React;

https://www.primefaces.org/primereact/#/inputswitch

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 23, 2018
@cagataycivici cagataycivici added this to the 6.0.2 milestone Jul 23, 2018
@cagataycivici cagataycivici self-assigned this Jul 23, 2018
@Lugdunumn
Copy link

@cagataycivici New InputSwitch implementation seems broken with Bootstrap theme, style was messed up, though the component works.

@osoDev
Copy link

osoDev commented Jul 27, 2018

Did you intentially remove onLabel and offLabel?
Is there some new approach to define custom texts?

@jkyoutsey
Copy link

Yeah, the removal of onLabel and offLabel is a breaking change that should have been communicated as part of a major release number, not 6.0.1 -> 6.0.2. Spent a lot of time scrambling this morning to figure out what the heck happened!

@osoDev
Copy link

osoDev commented Aug 8, 2018

So whats the new approach to define labels for On and Off state?

@kt215
Copy link
Contributor

kt215 commented Sep 1, 2018

The display text is now decoupled from the control. So you need to react to the InputSwitch state change and update your text accordingly.

@shorley
Copy link

shorley commented Sep 3, 2018

The inputswitch style on bootstrap theme is still broken on update 6.1.3. It shows a plain blue background without the switch.

@lichao10424
Copy link

The inputswitch style on bootstrap theme is still broken on update 6.1.4.
So I have to trun to v6.0.0 to use this, wish it will work well soon.

@obtdap
Copy link

obtdap commented Mar 26, 2019

The inputswitch style on bootstrap theme is still broken on update 7.1.0. It shows a plain blue background without the switch.
Any solutions planned ?

@Lugdunumn
Copy link

The inputswitch style on bootstrap theme is still broken on update 7.1.0. It shows a plain blue background without the switch.
Any solutions planned ?

Bootstrap theme is not maintained any more. I find inputswitch styles in nova theme and apply it. Should fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

8 participants