-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement InputSwitch #6134
Comments
@cagataycivici New InputSwitch implementation seems broken with Bootstrap theme, style was messed up, though the component works. |
Did you intentially remove onLabel and offLabel? |
Yeah, the removal of onLabel and offLabel is a breaking change that should have been communicated as part of a major release number, not 6.0.1 -> 6.0.2. Spent a lot of time scrambling this morning to figure out what the heck happened! |
So whats the new approach to define labels for On and Off state? |
The display text is now decoupled from the control. So you need to react to the InputSwitch state change and update your text accordingly. |
The inputswitch style on bootstrap theme is still broken on update 6.1.3. It shows a plain blue background without the switch. |
The inputswitch style on bootstrap theme is still broken on update 6.1.4. |
The inputswitch style on bootstrap theme is still broken on update 7.1.0. It shows a plain blue background without the switch. |
Bootstrap theme is not maintained any more. I find inputswitch styles in nova theme and apply it. Should fix the problem. |
Modernize it using a css only approach like we did in React;
https://www.primefaces.org/primereact/#/inputswitch
The text was updated successfully, but these errors were encountered: