Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement OverlayPanel Visibility #6140

Closed
cagataycivici opened this issue Jul 23, 2018 · 1 comment
Closed

Reimplement OverlayPanel Visibility #6140

cagataycivici opened this issue Jul 23, 2018 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
6.0.2

Comments

@cagataycivici
Copy link
Member

Instead of hide/show with css display property use *ngIf so when it gets visible, dialog dom should be created and similarly gets removed from dom when it is not visible. This will keep the dom size small as dialogs will work in a lazy manner and only exist in dom when they are visible.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 23, 2018
@cagataycivici cagataycivici added this to the 6.0.2 milestone Jul 23, 2018
@cagataycivici cagataycivici self-assigned this Jul 23, 2018
@machfalcon
Copy link

There is a defect related to this change which has been logged here: #6180

When an overlay panel or dialog which is appended to body is destroyed without being displayed, the container is never set and causes an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
6.0.2
Development

No branches or pull requests
2 participants
@cagataycivici @machfalcon