Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password feedback error #6182

Closed
skormel opened this issue Jul 30, 2018 · 4 comments
Closed

Password feedback error #6182

skormel opened this issue Jul 30, 2018 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@skormel
Copy link

skormel commented Jul 30, 2018

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
After upgrading primeng to 6.0.2 the password streth indicator of password component stop working

Expected behavior
When you set feedback to false the streth indicator should be hidden.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 6.1.0
  • PrimeNG version: 6.0.2
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version = 10.7.0

@fperezgaliana
Copy link

I have the same problem after updating to version 6.0.2. Here's an example:

https://stackblitz.com/edit/github-shjj86?embed=1&file=src/app/app.component.html

@dennyak47
Copy link

same problem here.
I check the code.
Line 67 is the problem
see commit f3fc120

@nwavesu
Copy link

nwavesu commented Aug 7, 2018

On PrimeNG version: 6.1.0 the same problem :(

@JacobSiegle
Copy link
Contributor

JacobSiegle commented Aug 8, 2018

EDIT: Never mind it works on one of my password components, but then not the other.

@cagataycivici cagataycivici changed the title Password feedback error 6.0.2 Password feedback error Aug 14, 2018
@cagataycivici cagataycivici self-assigned this Aug 14, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 14, 2018
@cagataycivici cagataycivici added this to the 6.1.1 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants